fix(adapters): preserve long tool names across Chat Completions - #195
Draft
MisterWanted wants to merge 1 commit into
Draft
fix(adapters): preserve long tool names across Chat Completions#195MisterWanted wants to merge 1 commit into
MisterWanted wants to merge 1 commit into
Conversation
Use one request-local reversible codec for declarations, forced choice and history. Reserve conforming names and resolve alias collisions with salted SHA-256 suffixes. Restore original names in JSON and streaming responses without changing call IDs or arguments.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun test tests/adapter-usage.test.ts tests/openai-chat*.test.ts: 97 passed, 0 failed, 382 assertions.bun run typecheck,bun run privacy:scan,git diff --check: passed.cd docs-site && bun install --frozen-lockfile && bun run build: passed, 156 pages.bun run test: NOT GREEN. Repository watchdog ended both seven-minute attempts (841 seconds total, exit 137) on a heavily contended eight-thread host. The old orphan-alias assertion was fixed with round-trip coverage; unrelated stream/timing failures and catalog/desktop timeouts are not claimed resolved. A main-runtime baseline is being checked separately.Linear
Checklist