Conversation
Collapse identically named processes into one chooser row and offer a submenu to kill all or pick individuals. Port and PID searches stay exact. Co-authored-by: Wisernage <Wisernage@users.noreply.github.com>
Pack chooser options into one object and format named exports so xo passes. Co-authored-by: Wisernage <Wisernage@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group identically named processes in the interactive chooser and add a submenu to kill all of them or pick individuals.
Google Chrome (12)cmdwhen--verbose):8080) and PID searches stay ungrouped/exactisHelperProcessfilter is unchangedgroupByNamehelper with unit testsFixes sindresorhus#6
IssueHunt $40 bounty
Tests:
xois clean aside from two pre-existing warnings. New grouping unit tests pass. Existing name-match integration tests that depend onnoopProcesstitles (default case-insensitive behavior,smart-case with lowercase) fail in this environment becausefkillcannot see those process titles; that path is unchanged.