Conversation
Call response.set_resolved_model() from the OpenAI response model field when it is nonempty and differs from the configured model id. Covers Chat, AsyncChat, Responses, AsyncResponses, and Completion. Fixes simonw#1681.
Wisernage
force-pushed
the
fix/openai-resolved-model-1681
branch
from
September 19, 2026 14:35
2077465 to
1b47e45
Compare
Wisernage
changed the title
Wisernage
force-pushed
the
fix/openai-resolved-model-1681
branch
2 times, most recently
from
September 19, 2026 14:36
2077465 to
1b47e45
Compare
Wisernage
changed the title
Wisernage
force-pushed
the
fix/openai-resolved-model-1681
branch
from
September 19, 2026 14:36
1b47e45 to
2077465
Compare
Wisernage
changed the title
Wisernage
force-pushed
the
fix/openai-resolved-model-1681
branch
2 times, most recently
from
September 19, 2026 14:37
1b47e45 to
2077465
Compare
Wisernage
changed the title
Wisernage
force-pushed
the
fix/openai-resolved-model-1681
branch
3 times, most recently
from
September 19, 2026 16:07
2077465 to
1b47e45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements simonw#1681.
Call
response.set_resolved_model()from the OpenAI Chat/AsyncChat responsemodelfield when it is present and differs from the requestedmodel_id. Zero extra API calls.OpenJobs
1c1c36f6-3994-404c-adf2-ffcd91fb211cNote: upstream PR simonw#1682 (adity982) is a separate broader draft. This PR stays scoped to Chat/AsyncChat as requested in simonw#1681 / the OpenJobs listing.
Test plan
pytest tests/test_openai_resolved_model.py(20 passed)