Skip to content

Race condition between building the tooltip for an item in inventory and disassembling that same item #749

Description

@DeviousNess95

This is an extremely minor issue. Truthfully, I only noticed it because I use Drop and Disassemble Hotkey from ModDB, and tend to spam disassembly because I'm a loot goblin and disassembling was getting tedious through the menu. I could just cool my rapid-fire clicking, but I love this project and so figured I'd offer a fix.

Based on the stack trace, it looked like the UI was trying to build the tooltip description for the item I was disassembling, so after the call to hspairs, but before the call to pairs, the value t was getting set to nil.

To recreate:

  1. Add Drop and Disassemble Hotkey
  2. Bind a key to disassemble in MCM (unbound by default)
  3. Disassemble items in rapid succession. In the CTD save I captured (ask if you need it), I was disassembling a stack of PL-15s.
  4. CTD, rinse and repeat.

Excerpt from the log around the crash: excerpt.log

Anyway, I'll have a PR in momentarily.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions