Migrate all colour values to LinearRgba from the colour crate#37
Merged
Conversation
Replace ad-hoc [f32; 4] and glam::Vec4 colour values across the engine with the typed LinearRgba from the color crate. Adds encase::ShaderType to LinearRgba so it can be used directly in GPU-uniform structs like RenderLight and WorldEnvironment without conversion boilerplate. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018cvaSayH5TaUEomfFBuJBd
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018cvaSayH5TaUEomfFBuJBd
GuilhermeGSousa
force-pushed
the
claude/colour-value-migration-vjd6ye
branch
from
19ccb4c to
83c3021
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace ad-hoc [f32; 4] and glam::Vec4 colour values across the engine
with the typed LinearRgba from the color crate. Adds encase::ShaderType
to LinearRgba so it can be used directly in GPU-uniform structs like
RenderLight and WorldEnvironment without conversion boilerplate.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_018cvaSayH5TaUEomfFBuJBd