Closed
Conversation
Owner
|
So overall, this PR is not really useful considering it's simply copying unknown target content. Therefore, I propose you the followings:
|
1e9105e to
7ba3f63
Compare
7ba3f63 to
8f213b4
Compare
GuillaumeGomez#433 - Recognizes FreeBSD based on cfg data - None of the functions are implemented yet.
8f213b4 to
e3f7749
Compare
Contributor
Author
|
What is the minimal functionality that needs to be present for you to merge this? |
Owner
|
Support for most functionalities. If something cannot be supported, (like |
Owner
|
Closing in favor of #620. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#433
As you may recognize this is mostly based on
unknown, but with things likeinstead of
I'm not sure why that's needed but without this it was failing to build with errors like this:
This error happens on an unmodified master branch as well as you can see here.