Add Dockerfile and deployment instructions#2
Open
ffevotte wants to merge 1 commit into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
==========================================
+ Coverage 63.51% 65.54% +2.03%
==========================================
Files 5 5
Lines 222 238 +16
==========================================
+ Hits 141 156 +15
- Misses 81 82 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using a
docker+docker-composesetup to deployLocalPackageServerinstances in my local network, and thought it could be of relatively general use (which I think is confirmed by #1).This PR implements a deployment procedure based on
docker-composeand customizable via a.envconfiguration file (a setup which is largely inspired byPkgServer.jl). Everything should be documented in thedeploy/README.mdfile, but please feel free to ask for more documentation if you feel like some details are missing.Of course, comments & criticism are welcome!
If this PR is merged, deploying a
LocalPackageServerinstance should be as easy as cloning the git repo, editing the.envfile and running make. As a further step, it should be possible to integrate this github repo with docker hub, which IIUC would allow docker hub to always provide an up-to-date image forLocalPackageServer(in much the same way as one is available forPkgServer). If we decide to go down that route, deploying aLocalPackageServerinstance could become as simple as running onedocker(ordocker-compose) command, without having to clone or install anything on the host machine.