Skip to content

🎨 Palette: Improve Multiselect UX with Native Constraints - #58

Open
Gunnarguy wants to merge 1 commit into
mainfrom
ux-multiselect-constraints-5707392937967262269
Open

Gunnarguy wants to merge 1 commit into
mainfrom
ux-multiselect-constraints-5707392937967262269

Conversation

@Gunnarguy

@Gunnarguy Gunnarguy commented Jul 6, 2026

Copy link
Copy Markdown
Owner

💡 What: Added max_selections=4 to the "Units" st.multiselect in the Team Lab section and removed the reactive warning and truncation logic.
🎯 Why: It provides a smoother user experience by preventing user errors entirely (selecting > 4 units) rather than letting them do it and punishing them with a warning afterwards.
♿ Accessibility: Ensures that keyboard navigation and screen readers correctly communicate the maximum number of items right away, rather than causing confusion post-selection.


PR created automatically by Jules for task 5707392937967262269 started by @Gunnarguy

Summary by Sourcery

Enforce a maximum of four unit selections in the Team Lab multiselect using native Streamlit constraints and update related helper text and documentation to reflect the improved UX.

New Features:

  • Add a max selections constraint to the Team Lab "Units" multiselect to cap analysis at four units.

Enhancements:

  • Replace manual selection truncation and warning logic with Streamlit's native max selections behavior for a smoother user experience.
  • Update the Team Lab help text to more clearly describe the analysis performed on selected units.
  • Document the design guideline favoring native Streamlit input constraints over custom validation in the Jules palette.

Co-authored-by: Gunnarguy <110250624+Gunnarguy@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 6, 2026 08:05
@sourcery-ai

sourcery-ai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR improves the Team Lab "Units" multiselect UX by enforcing Streamlit’s native max-selections constraint instead of manual post-selection validation, and documents the design rationale in the palette guide.

Sequence diagram for updated Team Lab units multiselect constraints

sequenceDiagram
  actor User
  participant TeamLab as render_team_lab
  participant Streamlit as st

  User->>TeamLab: render_team_lab
  TeamLab->>Streamlit: st.multiselect max_selections=4
  alt selections<=4
    Streamlit-->>TeamLab: selected_variant_ids
  else [selection_limit_reached]
    Streamlit-->>User: constraint_feedback
  end
  opt [no selections]
    TeamLab->>Streamlit: st.info
  end
Loading

File-Level Changes

Change Details Files
Use Streamlit’s native max_selections constraint on the Team Lab Units multiselect and remove manual truncation/warning logic.
  • Add max_selections=4 to the Units st.multiselect call in render_team_lab.
  • Update the multiselect help text to describe the SP economy and defensive coverage analysis while still indicating the 4-unit limit.
  • Remove the conditional that checks for more than 4 selected units and truncates the list with a warning banner.
  • Keep the empty-state st.info message, still referencing the 4-unit limit when no units are selected.
src/grandchase_meta_analyzer/explorer_app.py
Document the UX guideline favoring native Streamlit input constraints over manual validation in the Palette documentation.
  • Add a new palette entry dated 2025-06-18 describing the benefits of native Streamlit input constraints like max_selections.
  • Record the action item to prefer native Streamlit kwargs (e.g., max_selections, max_chars) instead of custom warning/error logic when enforcing input limits.
.Jules/palette.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the Team Lab “Units” selection UX in the Streamlit explorer app by enforcing the “up to 4 units” constraint directly in the st.multiselect widget, removing the need for reactive truncation/warnings. It also documents the design guideline to prefer native Streamlit input constraints.

Changes:

  • Add max_selections=4 to the Team Lab “Units” st.multiselect and remove the post-selection warning + truncation behavior.
  • Update the multiselect help text to describe what the selection is used to analyze.
  • Add a Jules palette guideline recommending native Streamlit input constraints over manual validation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/grandchase_meta_analyzer/explorer_app.py Enforces a 4-unit limit via Streamlit’s max_selections and removes reactive truncation/warning logic.
.Jules/palette.md Documents the UX guideline to prefer native Streamlit input constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants