fix(development/include/gxinvoke.h): DLMS_IGNORE_SERVER causes build error (missing bracket })#14
Open
ece-mohammad wants to merge 1 commit intoGurux:masterfrom
Conversation
…d error (missing bracket `}`) TLDR: In `gxinvoke.h` the `#endif //DLMS_IGNORE_SERVER` was placed before the linkage scope closing bracket. In `gxinvoke.h` there's an overlap between the `DLMS_IGNORE_SERVER` and the `C` linkage definitons. They are opened and closed in different order. Which leaves an un-closed linkage scope, when `DLMS_IGNORE_SERVER` is defined. Signed-off-by: ece-mohammad <kuro.ece@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
In
gxinvoke.hthe#endif //DLMS_IGNORE_SERVERwas placed before the linkage scope closing bracket.Details
In
gxinvoke.hthere's an overlap between theDLMS_IGNORE_SERVERand theClinkage definitons. They are opened and closed in different order. Which leaves an un-closed linkage scope, whenDLMS_IGNORE_SERVERis defined.