[ H4ck3r-netizen ] [ Crypto ] Fix MultiSigWallet confirmation race condition during execution callback#2
Open
H4ck3r-netizen wants to merge 571 commits into
Open
[ H4ck3r-netizen ] [ Crypto ] Fix MultiSigWallet confirmation race condition during execution callback#2H4ck3r-netizen wants to merge 571 commits into
H4ck3r-netizen wants to merge 571 commits into
Conversation
- Add block.chainid to signed message hash via EIP-712 domain separator to prevent cross-chain replay attacks - Add per-sender nonce mapping (replacing global nonce) to prevent same-chain replay attacks - Include contract address in EIP-712 domain separator to prevent replay after proxy upgrades - Add explicit zero-address check on ecrecover return value - Implement full EIP-712 typed data signing with domain separator (name, version, chainId, verifyingContract) - Add getNonce(address) view function for querying per-sender nonces - Add zero-address validation in constructor for _bridgeToken and _validator Fixes UnsafeLabs#920
- Add reentrancy guard (nonReentrant modifier) to executeTransaction - Add confirmation snapshot tracking to detect revocations during callback - Add blockConfirmations mapping for block-level confirmation queries - Add isConfirmedAtBlock() and getConfirmationCountAtBlock() functions - Add zero-address validation on 'to' in submitTransaction - Add code-size awareness for contract targets - Add zero-address validation for owners in constructor - Post-execution verification that confirmations weren't revoked Closes UnsafeLabs#916
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes UnsafeLabs#916