fix: require edit mode for separator changes - #26
Open
cmdr-chara wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents separator controls from changing the bar layout while the bar is locked.
barUnlockedfor V1 within-region split handles.barUnlockedfor V1 left/center/right boundary split handles.barUnlockedfor V2 separator handles.Why
Separator
MouseAreas were still active when the layout was locked, so an ordinary click near a separator could accidentally merge or split bar sections. This could, for example, join the center and right sections into one large pill.The change keeps separator editing available in edit mode while making the locked layout read-only.
Scope
This is intentionally small: it does not change separator persistence, drag-and-drop behavior, bar geometry, or styling.
Regression coverage
tests/qs-bar-edit-lock-regression.shverifies that the V1mkMaandbMahandles and the V2sepMahandle all requirebarSlot.root.barUnlocked.