Skip to content

fix: require edit mode for separator changes - #26

Open
cmdr-chara wants to merge 1 commit into
HANCORE-linux:mainfrom
cmdr-chara:fix/lock-separator-editing
Open

fix: require edit mode for separator changes#26
cmdr-chara wants to merge 1 commit into
HANCORE-linux:mainfrom
cmdr-chara:fix/lock-separator-editing

Conversation

@cmdr-chara

@cmdr-chara cmdr-chara commented Aug 22, 2026

Copy link
Copy Markdown

Summary

Prevents separator controls from changing the bar layout while the bar is locked.

  • Require barUnlocked for V1 within-region split handles.
  • Require barUnlocked for V1 left/center/right boundary split handles.
  • Require barUnlocked for V2 separator handles.
  • Add a regression script that checks all three edit handles remain gated by unlock mode.

Why

Separator MouseAreas were still active when the layout was locked, so an ordinary click near a separator could accidentally merge or split bar sections. This could, for example, join the center and right sections into one large pill.

The change keeps separator editing available in edit mode while making the locked layout read-only.

Scope

This is intentionally small: it does not change separator persistence, drag-and-drop behavior, bar geometry, or styling.

Regression coverage

tests/qs-bar-edit-lock-regression.sh verifies that the V1 mkMa and bMa handles and the V2 sepMa handle all require barSlot.root.barUnlocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant