Skip to content

Capture server exception as an action exception #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kostyanf14 wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Capture server exception as an action exception #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rtoolsHCK.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ def handle_action_exceptions(action, &block)
log_action_call(action, block.binding)
handle_exceptions do
yield
rescue RToolsHCKActionError => e
rescue RToolsHCKError => e
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadening the exception type from RToolsHCKActionError to RToolsHCKError will now also catch RToolsHCKConnectionError exceptions (including ServerError and EtherError). While this aligns with the PR's goal to handle server exceptions, it changes the behavior for all methods using handle_action_exceptions. Consider whether all connection errors should be uniformly treated as retriable action errors. If some connection errors require different handling, you might need a more nuanced approach that distinguishes between different types of connection failures.

Suggested change
rescue RToolsHCKError => e
rescue RToolsHCKActionError => e

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@kostyanf14 kostyanf14 Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to retry requests always and see how this will work in real system

action_exception_handler(e)
end
end
Expand Down
Loading