Updated h5dump --xml#6394
Conversation
The location of the files HDF5-File.xsd and HDF5-File.dtd no longer exists, and the files were added to the repo (PR HDFGroup#5490). Before the --xml is actually removed, running the h5dump tests will fail. This PR updated h5dump and the expected output to use the correct files' location and actually completed the ticket HELP-2668.
bmribler
requested review from
derobins,
fortnern,
jhendersonHDF,
lrknox and
qkoziol
as code owners
bmribler
requested review from
brtnfld,
glennsong09,
mattjala and
vchoi-hdfgroup
as code owners
@bmribler what did you mean by this? |
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <hdf5:HDF5-File xmlns:hdf5="http://hdfgroup.org/HDF5/XML/schema/HDF5-File.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://hdfgroup.org/HDF5/XML/schema/HDF5-File http://www.hdfgroup.org/HDF5/XML/schema/HDF5-File.xsd"> | |||
There was a problem hiding this comment.
At a first glance, it seems to me like these should remain as web URLs rather than local files
There was a problem hiding this comment.
The files are now in the repo. Should I use the GH repo develop branch for the location?
| @@ -1597,8 +1597,8 @@ main(int argc, char *argv[]) | |||
| "<%sHDF5-File xmlns:%s=\"http://hdfgroup.org/HDF5/XML/schema/HDF5-File.xsd\" " | |||
There was a problem hiding this comment.
But having said that, it seems this would need to be updated as well if changing the URLs
There was a problem hiding this comment.
These are just names, the files won't be looked for by anything, if I'm not mistaken. I was thinking about using the GH repo URLs, but waited to ask when this is brought up.
@jhendersonHDF Thanks for looking at this. I'm not sure which part of that sentence you're asking about, so I explain the full context. --xml is deprecated, but before it is officially removed from h5dump, the tests should still work. Currently, because the location of those files no longer exist, tests will fail when those tests run. Please let me know if I have misunderstood anything. |
I was asking about the part mentioning those tests failing since we currently run the h5dump xml tests and they pass as they're only checking the diff output |
3 participants
The location of the files HDF5-File.xsd and HDF5-File.dtd no longer exists, and the files were added to the repo (PR #5490). Before the --xml option is actually removed, running the h5dump --xml tests will fail. This PR updated h5dump and the expected output to use the correct files' location and actually completed the ticket HELP-2668.