Skip to content

Add tyre spray and smoke effect (fix #143)#241

Draft
hbeni wants to merge 8 commits into
masterfrom
tyresmoke
Draft

Add tyre spray and smoke effect (fix #143)#241
hbeni wants to merge 8 commits into
masterfrom
tyresmoke

Conversation

@hbeni

@hbeni hbeni commented Jan 8, 2018

Copy link
Copy Markdown
Collaborator

Fix #240 (duplicate issue)
Fix #143

  • wheel spray effect
  • tyre smoke effect canceled, not for cessna
    Edit:
  • prop spray effect (when wet surfaces)
  • prop dust effect (on dry surfaces)

@HHS81

HHS81 commented Jan 8, 2018

Copy link
Copy Markdown
Owner

There is no tyre smoke on a real Cessna landing. To less speed on touchdown

@hbeni

hbeni commented Jan 8, 2018

Copy link
Copy Markdown
Collaborator Author

spray and smoke working (default implementation)

(it rains cats and dogs here, but rainfall not visible on image):
image

A little rough landig at good weather:
image

@HHS81

HHS81 commented Jan 8, 2018

Copy link
Copy Markdown
Owner

Sorry, but that doesn't look realistic. Have you ever seen a little cessna producing so much smoke like a big airliner? There is no tyre smoke on real landing. Can't be, to less speed on touchdown.

And even while raining it is too much. And framerates.... 😑

@hbeni hbeni changed the title Add tyre spray effect (fix #240) Add tyre spray and smoke effect (fix #240) Jan 8, 2018
@hbeni

hbeni commented Jan 8, 2018

Copy link
Copy Markdown
Collaborator Author

@HHS81 thanks for the feedback, i just tought i quickly implement this with the hints on the wiki.
i notice no performance hit, but i didn't check numbers either.

Should i investigate how to tune the water-spray effect down and remove the smoke alltogether?
Or should we leave that feature alone?

@hbeni

hbeni commented Jan 8, 2018

Copy link
Copy Markdown
Collaborator Author

I removed smoke and tuned down the spray; how is this now?
image
image

@hbeni

hbeni commented Jan 8, 2018

Copy link
Copy Markdown
Collaborator Author

just measured it. Driving along in rain with the patch is about 21-23FPS here (and my machine is rather old), doing the same at the same rainy weather on master is 22-23; so a little faster at the lower band.
What numbers do you get?

Heiko Schulz added 3 commits January 29, 2018 01:29
Signed-off-by: Heiko Schulz <Heiko Schulz>
Signed-off-by: Heiko Schulz <Heiko Schulz>
Signed-off-by: Heiko Schulz <Heiko Schulz>
@HHS81

HHS81 commented Jan 29, 2018

Copy link
Copy Markdown
Owner

fgfs-screen-004

still a lot of work until it is ready

@hbeni hbeni changed the title Add tyre spray and smoke effect (fix #240) Add tyre spray and smoke effect (fix #143) Feb 17, 2018
@hbeni

hbeni commented Dec 7, 2020

Copy link
Copy Markdown
Collaborator Author

still a lot of work until it is ready

@HHS81 Hi Heiko, what exactly is missing / should be adjusted? (i think it looks good already)
If i have time the next few weeks i maybe can finish this off (we should not wait for the next fgaddon release i think; but maybe the current state is already mergeable enough for you; then i will fix the conflicts shortly)

@hbeni hbeni marked this pull request as draft December 16, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add framerate friendly prop dust and spray effect. Implement Tyre Spray and smoke

2 participants