Skip to content

Issue-21 Better magneto switch key model#532

Draft
wlbragg wants to merge 5 commits into
masterfrom
Issue21_better_magneto_key_switch
Draft

Issue-21 Better magneto switch key model#532
wlbragg wants to merge 5 commits into
masterfrom
Issue21_better_magneto_key_switch

Conversation

@wlbragg

@wlbragg wlbragg commented Nov 25, 2023

Copy link
Copy Markdown
Collaborator

Fixes #21
Fixes #460

@hbeni
FYI: There is a duplicate LMPanel.png (c182/Models/LMPanel.png). It was already there when I started this PR so I left it. It is the original one though and is not being use by anything as far as I am aware of. It should probably be removed so as not to ever get used or accidentally replace the one in c182/Models/Effects/LMPanel.png.

@hbeni

hbeni commented Nov 25, 2023

Copy link
Copy Markdown
Collaborator

Cool, thanks!
Will have a look at this shortly. I think it would be a good idea to also have @HHS81 look over this, as I‘m not having a clue on the tecnical aspect if this.

Will this work on the c182t also automatically?

@hbeni

hbeni commented Nov 25, 2023

Copy link
Copy Markdown
Collaborator

From my point of view it does look good.

Also with removal of the duplicate Lightmap all is fine.

@wlbragg

wlbragg commented Nov 25, 2023

Copy link
Copy Markdown
Collaborator Author

Will this work on the c182t also automatically?

No, I forgot to look at the c182t. I can port it to the 182t as well. The glareshield lightmap on the 182t is broken, but now that i am familiar with the panel layouts and the lightmaps. let me go ahead and try to port the key to the 182t and fix the glareshield lightmap for it.

@hbeni

hbeni commented Nov 25, 2023

Copy link
Copy Markdown
Collaborator

That will be great!

@hbeni

hbeni commented Nov 28, 2023

Copy link
Copy Markdown
Collaborator

@wlbragg Just noticed this: #460
I assume this gets fixed by your new lightmap as well?

@wlbragg

wlbragg commented Nov 28, 2023

Copy link
Copy Markdown
Collaborator Author

I assume this gets fixed by your new lightmap as well?

Yes, I noticed it as well. I made a lightmap blend and separated all the objects per their textures so they can all be baked as needed. It also will enable any future additions to be added to the blend and the lightmaps.

@hbeni

hbeni commented Dec 11, 2023

Copy link
Copy Markdown
Collaborator

Hi @wlbragg, how is it proceeding? :)

@wlbragg

wlbragg commented Dec 11, 2023

Copy link
Copy Markdown
Collaborator Author

December is a busy month for me, so it's going slow trying to devote time. But there really isn't that much to do so maybe I can get it done this year!

@hbeni hbeni marked this pull request as draft December 16, 2023 18:33
@hbeni

hbeni commented Jan 5, 2024

Copy link
Copy Markdown
Collaborator

@wlbragg happy new year;
is this mergeable for the c182s already (up to d62eda3) or are there constraints re. C182T preventing this?

@wlbragg

wlbragg commented Jan 8, 2024

Copy link
Copy Markdown
Collaborator Author

Happy new year back at you!
Technically yes up to d62eda3. Can you do that? I will try to wrap the 182t portion up in the next week or two. I got engrossed in the ws3.0 stuff. It shouldn't take long to finish the 182t lightmap.

@hbeni

hbeni commented Jan 8, 2024

Copy link
Copy Markdown
Collaborator

Merged fde0e5a and d62eda3; tested, looks OK.

@hbeni hbeni mentioned this pull request Jan 8, 2024
2 tasks
@hbeni

hbeni commented Nov 17, 2025

Copy link
Copy Markdown
Collaborator

@wlbragg I totally lost this; I think this is not yet resolved, isn't it?

@wlbragg

wlbragg commented Nov 20, 2025

Copy link
Copy Markdown
Collaborator Author

Let me review and I will get back to you.

@wlbragg

wlbragg commented Nov 27, 2025

Copy link
Copy Markdown
Collaborator Author

@hbeni looks like the 182T lightmaps are not finished. If you don't hear from me by Jan 9th, please yank my chain and I will for sure try to finish this up. I might be able to work on it prior, but this is my busiest time of the year. Thanks for bringing it to my attention. Regardless of what happens and what we change with HDR/PBR, it'd be nice to have this finished and included in the history.

@wlbragg

wlbragg commented Nov 27, 2025

Copy link
Copy Markdown
Collaborator Author

I took a closer look at this and I am further along than I thought. The glareshield lightmap looks like it has almost everything included. It also is currently controlling the pedestal portion and needs to be seperated. So it is close. I will try to finish in the next days to weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C182T: Pedestal lightmap is broken better magneto switch key model

2 participants