Replace poetry, black, and flake8 by uv and ruff#6
Merged
BerndDoser merged 8 commits intoHITS-AIN:mainfrom May 26, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces Poetry, Black, and Flake8 with uv and ruff by updating project dependencies, CI steps, and removing old config files.
- Move from Poetry to uv for dependency management and test execution.
- Replace Black and Flake8 linting/formatting with ruff in CI.
- Remove obsolete .flake8 config and adjust project metadata.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_gaia_converter.py | Removed extraneous blank lines in test definitions |
| tests/test_fits_converter.py | Removed extraneous blank lines in test definitions |
| src/pest/spherinator_data_preprocessing.py | Reformatted assert statements and removed trailing spaces |
| pyproject.toml | Added uv, moved/lifted pytest, added ruff dependency |
| .github/workflows/python-package.yml | Switched from Poetry steps to uv and ruff in CI |
| .flake8 | Removed old Flake8 configuration |
| devel/test_chunks.ipynb | Quote style change in notebook |
| devel/show_parquet.ipynb | Removed unused import cell from notebook |
Comments suppressed due to low confidence (2)
devel/show_parquet.ipynb:150
- [nitpick] The removal of the import cell in this notebook is unrelated to the main changes and adds noise; consider reverting or excluding notebook diffs in this scope.
"df = dataset.to_table().to_pandas()\n"
devel/test_chunks.ipynb:709
- [nitpick] This notebook change only adjusts quoting style and does not affect functionality; consider excluding generated notebooks from this PR to reduce noise.
"pq.read_table(\"part-0.parquet\").to_pandas()"
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project’s tooling by replacing poetry, black, and flake8 with the faster uv and ruff tools while adjusting configuration files and workflows accordingly.
- Removed extraneous blank lines and reformatted print statements and other expressions for conciseness.
- Updated the pyproject.toml and workflow configurations to support uv and ruff integration.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_gaia_converter.py | Removed redundant blank lines in test functions. |
| tests/test_fits_converter.py | Consolidated argument passing in test functions. |
| src/pest/spherinator_data_preprocessing.py | Reformatted print statements and assertions for consistency. |
| src/pest/preprocessing.py | Reduced multi-line expression to a single line. |
| src/pest/gaia_converter.py | Minor formatting cleanup in lambda usage. |
| src/pest/fits_converter.py | Reformatted metadata replacements to single lines. |
| pyproject.toml | Updated dependencies and added ruff configuration sections. |
| devel/test_chunks.ipynb | Adjusted source string quotes. |
| devel/show_parquet.ipynb | Removed unused import lines. |
| .github/workflows/python-package.yml | Modified steps to use uv and updated checkout action version. |
| .flake8 | Removed as linting is now handled by ruff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv and ruff are extremely fast project management, Python linting, and code formatting tools written in Rust.
The
pyproject.tomlwas updated to work with bothpoetryanduv. In the GitHub action workflow,poetry,black, andflake8were replaced byuvandruff.