Skip to content

Refactor MASK_CAUSAL parameter to use IS_CAUSAL#294

Closed
LoserCheems wants to merge 1 commit into
quantfrom
flex-window
Closed

Refactor MASK_CAUSAL parameter to use IS_CAUSAL#294
LoserCheems wants to merge 1 commit into
quantfrom
flex-window

Conversation

@LoserCheems
Copy link
Copy Markdown
Collaborator

Summary

  • This change refactors the MASK_CAUSAL parameter to utilize IS_CAUSAL in kernel configurations for both dense and sparse operations.

Root Cause

  • The previous implementation used a hardcoded value for MASK_CAUSAL, which did not leverage the IS_CAUSAL parameter, leading to potential inconsistencies.

Changes

  • Updated the MASK_CAUSAL parameter in multiple kernel functions to reference IS_CAUSAL instead of a static true value.

Reproduction

  • No specific bug to reproduce; this is a refactor for improved parameter handling.

Tests

  • Existing tests validate the functionality of the kernels; no new tests were added as this is a refactor.

Compatibility

  • No backward compatibility issues; the change maintains the existing interface.

Checklist

  • Linked issue provided
  • Adds or updates tests
  • Updates docs if needed
  • No perf regressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant