Skip to content

Refactor MASK_CAUSAL parameter to use IS_CAUSAL#295

Merged
LoserCheems merged 1 commit into
mainfrom
flex-window
May 25, 2026
Merged

Refactor MASK_CAUSAL parameter to use IS_CAUSAL#295
LoserCheems merged 1 commit into
mainfrom
flex-window

Conversation

@LoserCheems
Copy link
Copy Markdown
Collaborator

Summary

  • This change refactors the MASK_CAUSAL parameter to utilize the IS_CAUSAL variable in kernel configurations for both dense and sparse operations.

Root Cause

  • The previous implementation used a hardcoded value for MASK_CAUSAL, which could lead to inconsistencies.

Changes

  • Updated the MASK_CAUSAL parameter in multiple kernel functions to reference IS_CAUSAL instead of a static True value.

Reproduction

  • No specific bug reproduction steps as this is a refactor, but ensure that kernel operations function as expected with the new parameterization.

Tests

  • Existing tests should cover the functionality; validation performed through regression testing.

Compatibility

  • No backward compatibility issues anticipated.

Checklist

  • Linked issue provided
  • Adds or updates tests
  • Updates docs if needed
  • No perf regressions

@LoserCheems LoserCheems merged commit 320f555 into main May 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant