Support A2540 microphone notifications - #4
Draft
gilwilliams520-hash wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
04 00 1B 36 00in addition to the existing A2854 signature04 00 1B 35 00.0x0037handle as a negative case.The live parser previously hard-coded the A2854 attribute handle
0x0035. A physical A2540 sends the same Opus frame format on attribute handle0x0036, so otherwise-valid second-generation voice frames were discarded.How it was verified
swift test --package-path SiriRemoteCore— 113 tests passedcd app && ./build.shcd mic/router && ./build.sh— parser test, monitor-ring test, and router build passedcd mic && ./build-test.sh— Opus decode, concealment, buffer, and WAV self-test passedWith the Siri button held, remote-microphone audio reached the virtual input and was successfully used for dictation. The A2540 sequence, payload length, and Opus TOC/layout matched the existing A2854 path.
Notes for the reviewer