Conversation
|
Hey, Lisa tasked me with checking the PRs for framework conventions and I found a few things to address before we can merge this:
Class naming
Helper files in the dimension folder
Docstrings Thanks! |
| @@ -0,0 +1,51 @@ | |||
| from __future__ import annotations | |||
|
|
|||
| import re | |||
There was a problem hiding this comment.
Please shortly comment what this does and why you couldn't use the python tokenization function
There was a problem hiding this comment.
@Tomic-Riedel thanks for all the comments. We agreed that "schema" granularity make sense for readability since we might also have more schema metrics in the future. For now, we focused on the data level per default.
| # Utilities | ||
| # ---------------------------- | ||
|
|
||
| def load_abbreviations(abbr_csv: Optional[str]) -> Dict[str, str]: |
There was a problem hiding this comment.
Also here, please shortly comment what this class is about
lisehr
left a comment
There was a problem hiding this comment.
LGTM and free to merge together with the other files, the small comments can be fixed lateron
No description provided.