Skip to content

feat: add default outline to jets for better overlap visibility#837

Open
rx18-eng wants to merge 1 commit intoHSF:mainfrom
rx18-eng:fix/jet-outline-visibility
Open

feat: add default outline to jets for better overlap visibility#837
rx18-eng wants to merge 1 commit intoHSF:mainfrom
rx18-eng:fix/jet-outline-visibility

Conversation

@rx18-eng
Copy link

summary

When multiple jets overlap in the 3D view, it's hard to tell where one ends
and another begins since they're semi-transparent cones with similar colors.

This adds a lightweight wireframe edge outline to each jet using a low-poly
cylinder (12 segments), slightly brighter than the jet fill color. Makes it
much easier to distinguish overlapping jets.

The default outline automatically hides when hover or selection outlines are
active to avoid visual clutter, and comes back when deselected.

Also fixes a small bug in share-link where getStateAsJSON() was renamed to
saveStateAsJSON().

Files

  • phoenix-objects.ts — adds EdgesGeometry outline as a child of the jet mesh
  • effects-manager.ts — toggles default outline visibility during
    hover/selection
  • share-link-dialog.component.ts — fix renamed method call
Screenshot 2026-03-13 031336

@rx18-eng
Copy link
Author

Hey @EdwardMoyse Please let me know your thoughts on this :)

@EdwardMoyse
Copy link
Collaborator

Hi @rx18-eng - I would like to discuss this with @sponce but I have to say that I don't really like this visually. Jets in physics are not physical objects but a shower of particles, and I think a wireframe like this is not very appealing, nor is it really giving a hint of the underlying physics.

Part of the reason for my delay was I was actually looking at the code, trying to work out how to revert the rainbow selection effect introduced in #721 (which in retrospect is too much) in favour of the much more elegant (in my opinion) outline effect we had before.

Back to this: I think it would be nice to see if we could distinguish the jets with a more subtle effect, perhaps with shaders, where the edges are opaque and the inside is more transparent? But this would perhaps be something to brainstorm.

@rx18-eng
Copy link
Author

rx18-eng commented Mar 20, 2026

Thanks for your review @EdwardMoyse ! Also just wanted to inform you this is my temporary account as replacement for remo-lab(untill the issue gets resolved :) )

Signed-off-by: rx18-eng <remopanda78@gmail.com>
@rx18-eng rx18-eng force-pushed the fix/jet-outline-visibility branch from 05784ec to 88e3da1 Compare March 22, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants