fix(event-display): replace rainbow selection shader with glow outline#841
Open
deveshbervar wants to merge 1 commit intoHSF:mainfrom
Open
fix(event-display): replace rainbow selection shader with glow outline#841deveshbervar wants to merge 1 commit intoHSF:mainfrom
deveshbervar wants to merge 1 commit intoHSF:mainfrom
Conversation
0d730fa to
43d7957
Compare
Collaborator
Author
|
Hi @EdwardMoyse, this PR addresses #839. Rather than a full revert, I kept the multi-selection architecture and performance improvements from #721 but made the following changes to
All interaction improvements from #721 are preserved (multi-selection, drag detection, double-click orbit, programmatic API). Please let me know if you'd prefer a different color scheme or a full revert instead — happy to adjust! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #839
What this does
Replaces the animated rainbow selection shader with a clean golden glow outline, addressing the visual concern raised in #839.
Changes
SELECTION_FRAGMENT_SHADERrainbow animation with a solid golden pulse (vec3(1.0, 0.85, 0.3))HOVER_FRAGMENT_SHADERstatic blue with a pulsing blue (vec3(0.3, 0.7, 1.0))RAINBOW_FUNCTIONconstant1for both hover and selection — removes the wireframe appearanceWhat is preserved from #721
Note
Local build has a pre-existing
BrowserslistError: Unknown version 146 of chromeissue on this machine unrelated to these changes.