Skip to content

Add translation sorting script, add format script, and change lint script to only check#5737

Draft
VillePihlava wants to merge 4 commits intov3from
add-translation-sorting
Draft

Add translation sorting script, add format script, and change lint script to only check#5737
VillePihlava wants to merge 4 commits intov3from
add-translation-sorting

Conversation

@VillePihlava
Copy link
Copy Markdown
Contributor

@VillePihlava VillePihlava commented Apr 9, 2026

Proposed Changes

  • Added a mostly AI generated file that sorts app/translations.js and a related sort-translations script
  • Added a format script for formatting the project
  • Changed the lint script to not change files at all, also checks if app/translations is translated
  • Update CI node version to 24.14.1

NOTE

  • Node version updated because reading translations.js with sort-translations.js has CommonJS/ESM problems.
  • Updating node version causes mocha tests to fail because of CommonJS/ESM problems.
  • For example: AppBar.test.js is parsed as ESM because of import instead of require. This causes failures later when using JSX elements

@VillePihlava VillePihlava changed the title Add translation sorting script and format script Add translation sorting script, add format script, and change lint script to only check Apr 9, 2026
@VillePihlava
Copy link
Copy Markdown
Contributor Author

VillePihlava commented Apr 9, 2026

I wonder if a check sorted translations script should be added for the lint script? This would make CI fail when not sorted

Edit: added it

@VillePihlava VillePihlava force-pushed the add-translation-sorting branch from 9f68301 to d9a3716 Compare April 9, 2026 19:55
@VillePihlava
Copy link
Copy Markdown
Contributor Author

The unit tests fail because of CommonJS/ESM problems described in the description. This is caused by an update to node v24. We will have to discuss how to solve them.

@VillePihlava VillePihlava marked this pull request as draft April 10, 2026 11:10
@VillePihlava
Copy link
Copy Markdown
Contributor Author

waiting for #5739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant