Optimize by fixing Fix CA1873 Roslyn suggestion#43
Merged
Conversation
Replaced inline log messages with `LoggerMessage` attribute based logging methods across classes. For readability they were extracted into separate files following the name schema `<filename>.logger.cs`. This was done to prevent a log execution validation of not execute log actions, because the log level not being met or because the logger is disabled in general. As all command paths are hot path, this was worth in regards of performance.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced inline log messages with
LoggerMessageattribute based logging methods across classes. For readability they were extracted into separate files following the name schema<filename>.logger.cs. This was done to prevent a log execution validation of not execute log actions, because the log level not being met or because the logger is disabled in general. As all command paths are hot path, this was worth in regards of performance.