Skip to content

Fixed Bug Resting\Bun in oven changePrices bug#31

Open
PantsStatusZero wants to merge 3 commits into
HaJaeKyung:masterfrom
PantsStatusZero:master
Open

Fixed Bug Resting\Bun in oven changePrices bug#31
PantsStatusZero wants to merge 3 commits into
HaJaeKyung:masterfrom
PantsStatusZero:master

Conversation

@PantsStatusZero

Copy link
Copy Markdown
Contributor

changePrices tries to convert Resting \ Bun in the oven status into US dollars which displays a NaN status. This change prevents that from happening.

changePrices tries to convert Resting \ Bun in the oven status into US dollars which displays a NaN status. This change prevents that from happening.
it was trying to convert hours to dollars on resting and bun in oven statuses
@PantsStatusZero

Copy link
Copy Markdown
Contributor Author

The return; in my fix should have been a continue;

                      let text = item.getElementsByTagName('span')[0].innerText;

                      if(text.toUpperCase().indexOf("HOURS")>0){
                          continue;
                      }

Before this fix
image

After this fix
image

@HaJaeKyung

Copy link
Copy Markdown
Owner

This should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants