Fix for dashboard page#210
Merged
Merged
Conversation
zkwsk
previously approved these changes
Apr 26, 2020
Collaborator
zkwsk
left a comment
zkwsk
left a comment
There was a problem hiding this comment.
I have some suggested changes, but given that things work the way you demoed it, I don't think any of them are merge- blockers, but some of it could be changed quite quick :)
Collaborator
|
Looks good 👍 |
gizemcandemir
requested changes
Apr 26, 2020
…to fix/dashboard-page
…-class11 into fix/dashboard-page
…to fix/dashboard-page
zkwsk
previously approved these changes
Apr 26, 2020
Collaborator
|
Great job! 💯 |
Contributor
|
Approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished status box / without status label
Fixed some issues
Fixed dashboard page without data, when stage is delivered
Fixed showing last 5 readings on charts based on date
Fixed flex issue @gizemcandemir