Get local time and update sensor_readings to UTC tz#228
Open
kfazinic wants to merge 2 commits into
Open
Conversation
zkwsk
requested changes
May 9, 2020
| const [date, time] = datetime.split('T'); | ||
| const datetimeTag = `${date}/${month} ${time}h`; | ||
| const [year, month, day] = date.split('-'); | ||
| const datetimeTag = `${day}/${month} ${time.slice(0, 2)}h`; |
Collaborator
There was a problem hiding this comment.
Any reason not to use moment for formatting the date? (Excepts that it was not used before)
| user: process.env.DB_USER, | ||
| password: process.env.DB_PASSWORD, | ||
| database: process.env.DB_NAME, | ||
| dateStrings: true, |
Collaborator
There was a problem hiding this comment.
What does this do? Force the DB to return strings? Why is that necessary? I would think it would be better to keep dates as timestamps for as long as possible and only render them into strings in the presentational components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: need to run
db:cleananddb:setuplocally and on the production DB after merging.