Skip to content

Conversation

@GayathriVenkatraman
Copy link
Contributor

@adamblanchard I have updated the "Learning Goals" for Final Project, also I have reviewed your PR (#242) . We could merge and close the PR 242 (as I do not have the option to merge the PR).

This PR has now updated "Learning Goals", also I made some changes on the module title and the session title.

@adamblanchard Please take a look and let's merge this PR as well.

Copy link
Contributor

@adamblanchard adamblanchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GayathriVenkatraman! just a couple of small comments.

I'm a little confused why my commits/changes are still showing up in here when I merged the other PR. Can you update your branch with the latest main and see if that helps? Otherwise let me know if you can see why, I'm a bit stumped, so must be missing something 🤯 😁

@@ -1,0 +1,3 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing this? cSpell isn't currently an official plugin in this project so might be better to keep this in your user settings rather than committing it for others too :)

"location": "courses/qa",
"modules": [
{
"name": "Basics of Testing",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the "name" values in this file too, based on the new names you wrote for the above modules? 🙇 This json is used to autogenerate different docs in the program, so we should replace them too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants