security: add SRI hash to Redoc CDN script tag#36
Open
dmchaledev wants to merge 1 commit into
Open
Conversation
The docs site loads redoc.standalone.js from jsdelivr with no integrity check, so a compromised or MITM'd CDN response would run unmodified in visitors' browsers. Pin it with a sha384 SRI hash (verified against jsdelivr's published sha256 for the same file) and crossorigin="anonymous".
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/index.htmlloadsredoc.standalone.jsfrom jsdelivr with a plain<script src>tag and no Subresource Integrity check.hailbytes.github.io/hailbytes-api-docs, a compromised CDN edge or MITM response would execute unmodified in every visitor's browser — SRI is the standard mitigation.integrity="sha384-..."andcrossorigin="anonymous"for the pinnedredoc@2.5.3bundle. The hash was computed locally from the fetched file and cross-checked against jsdelivr's own published sha256 for the same file (data.jsdelivr.com/v1/package/npm/redoc@2.5.3) — both point at identical bytes, confirming the pin is correct.Test plan
redoc.standalone.jsmatches jsdelivr's published content hash forredoc@2.5.3.Generated by Claude Code