Add Clear button, add Domain header, housekeeping #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndruC
commented
Jun 5, 2024
| console.log(ruleObject); | ||
| } | ||
|
|
||
| cssText = ruleContentToCssString(ruleObject['content']); |
AndruC
commented
Jun 5, 2024
| console.log(cssText); | ||
| } | ||
|
|
||
| if (cssText == "") { |
AndruC
commented
Jun 5, 2024
|
|
||
| <body> | ||
|
|
||
| <p id = "hostname-container" class = "flex block-container"> </p> |
Author
There was a problem hiding this comment.
Moved into #textbox-container. The rest is white-space.
AndruC
commented
Jun 5, 2024
AndruC
commented
Jun 5, 2024
Reordering for a cleaner diff.
Author
|
@HalilCan sorry for the ping. Is this project still being maintained? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily adds a Clear button, but in addition:
There was a Paragraph element hidden in the panel, so I repurposed it to show the domain.
I was confused as both a user and a developer looking at code, seeing the "Oops..." message, so this was clarified. Also, the text field has been emptied out when visiting a new domain. This prevents the need for users to manually delete the text each time.
I didn't think the extension had much of an identity, so I simplified the look across the board. This fixed a design bug in which button clicks (ie
activestate) had no visual distinction. I realize this is somewhat up to taste but I think it's an improvement until a stronger design is presented:This is pretty minor, but it helped me understand the structure of the code better when I was looking at making changes