feat(auth): overhaul SEP-10 JWT generation and rate limiting - #74
Merged
Conversation
0dillon
added a commit
that referenced
this pull request
Aug 29, 2026
Co-authored-by: enny791 <enny791@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a major overhaul of our authentication layer to ensure stability under high loads.
The JWT signing logic has been extracted into a centralized \AuthUtil.ts\ utility, and we have migrated from HS256 to the more robust RS256 algorithm. A new keypair is dynamically generated if not supplied via the environment, ensuring seamless development workflows.
Additionally, we've implemented a strict Redis-backed sliding window rate limiter directly scoped to the /auth/challenge\ endpoint to prevent brute-force attacks. We also added an integration test using mocked ioredis instances that verifies the system accurately issues 429 Too Many Requests responses after 100 requests per minute.
Closes #31.