Skip to content

fix(tests): fix rateLimit integration test #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0dillon merged 1 commit into from
Aug 29, 2026
Merged

fix(tests): fix rateLimit integration test #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/services/sep10.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export class SEP10AuthService {
network_passphrase: this.networkPassphrase
};
} catch (err: unknown) {
console.error('buildChallengeTx error:', err);
throw new AppError(400, 'CHALLENGE_BUILD_FAILED', 'Failed to generate SEP-10 challenge transaction', err);
}
}
Expand Down
11 changes: 8 additions & 3 deletions tests/rateLimit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,24 @@ jest.mock('ioredis', () => {
return RedisMock;
});

import { Keypair } from '@stellar/stellar-sdk';

describe('SEP-10 Rate Limiting Integration', () => {
it('should return 429 Too Many Requests after 100 requests', async () => {
// Generate a valid random Stellar public key for the test
const clientAccount = Keypair.random().publicKey();

// Send 100 successful requests
for (let i = 0; i < 100; i++) {
const res = await request(app)
.get('/api/v1/auth/challenge?account=GCXKG6RN4ONIEPCMNFB732A436Z5IGJUQYA8QW5FN6HP3SG6HQBQVAAK');
.get(`/api/v1/auth/challenge?account=${clientAccount}`);
expect(res.status).toBe(200);
}

// 101st request should be rate limited
const resLimited = await request(app)
.get('/api/v1/auth/challenge?account=GCXKG6RN4ONIEPCMNFB732A436Z5IGJUQYA8QW5FN6HP3SG6HQBQVAAK');
.get(`/api/v1/auth/challenge?account=${clientAccount}`);
expect(resLimited.status).toBe(429);
expect(resLimited.body.message).toBe('Rate limit exceeded. Please try again later.');
expect(resLimited.body.error.message).toBe('Too many requests from this IP, please try again later.');
});
});
Loading