chore(security): SSO security review + pyOpenSSL CVE fix#392
Merged
Conversation
Q2 governance item: SSO federation security review. Scan tools: - Bandit 1.9.4 (high+medium severity): 0 findings - Semgrep p/security-audit + p/owasp-top-ten + p/jwt + p/python (205 rules): 0 findings - pip-audit on SSO dependency subgraph: 2 real CVEs in pyOpenSSL 22.0.0 (transitive via pysaml2) Fix: - Pin pyOpenSSL==26.0.0 in requirements.txt (fixes CVE-2026-27448, CVE-2026-27459) Manual review findings (LOW, deferred as follow-ups, not exploitable): - SEC-SSO-02: OIDC nonce not implemented (mitigated by state + PKCE S256) - SEC-SSO-03: JWKS fetched on every callback without cache (performance + availability) Confirmed positive controls: 256-bit state, single-use, PostgreSQL-backed; PKCE S256; id_token signature verification with alg=none rejection; iss/aud/exp/nbf validation; SAML want_assertions_signed=True; authn_requests_signed=True; audit logging; trusted proxy for client IP; provider configs encrypted at rest. Review document: docs/SSO_SECURITY_REVIEW_2026-04-14.md
Whitelists docs/*_SECURITY_REVIEW_*.md (and OW_SECURITY_ASSESSMENT.md) in .gitignore so security review artifacts are tracked for audit trail, matching the existing pattern for OW_SECURITY_ASSESSMENT.md. Adds SSO_SECURITY_REVIEW_2026-04-14.md documenting the Q2 governance review per docs/OPENWATCH_Q2_PLAN.md Workstream G residual items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Q2 Workstream G residual item: SSO security review.
Summary
Automated + manual security review of the SSO federation code. One real transitive CVE chain fixed; two defense-in-depth items filed as follow-ups (#390, #391).
Changes
Tool results
Manual review — positive controls confirmed
Deferred findings (follow-up issues filed)
Neither is exploitable given existing controls; both are improvements.
Governance
This review is not a human security sign-off substitute for operational trust decisions:
Test plan