Skip to content

Add search filter functionality to dashboard.#609

Open
ghost wants to merge 1 commit intoHangfireIO:devfrom
eTechSolutions:JobSearch
Open

Add search filter functionality to dashboard.#609
ghost wants to merge 1 commit intoHangfireIO:devfrom
eTechSolutions:JobSearch

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 13, 2016 •
edited by ghost
Loading

Due to the sheer amount of Jobs being queued onto Hangfire it can be very difficult to find a job in the dashboard. We have added a search functionality into the Dashboard where we can search by:

  • Parameters being passed in.
  • Method names (Jobs that have been queued)
  • Date the Job was queued.

Other Changes:

  • We have broke the JavaScript into 3 different files as we felt it was getting difficult to maintain in one file.
  • Added JQuery DataPicker to be used for date search.

This is our companies first open source contribution so we are happy on any feedback on this pull request.

Thanks!

@ghost ghost force-pushed the JobSearch branch 2 times, most recently from 239f953 to d8db3be Compare July 13, 2016 15:22
@odinserj
Copy link
Copy Markdown
Member

odinserj commented Jul 13, 2016 •
edited
Loading

Awesome contribution, @stevetsang! But it contains breaking changes to the public IMonitoringApi interface. If I merge this PR, a lot of projects must be updated (including all the storages listed here), a lot of people who use the interface in their applications will be required to perform additional tasks also.

I've constrained 1.x versions to not to have breaking changes between releases. There are a lot of deprecated stuff I'd like to remove too, and a lot of interfaces I'd like to change (), but I simply can't do this – it will break the expectations and raise a lot of questions after upgrade.

There are two ways to get this feature done:

  1. Wait until 2.0 development will begin (I don't know when, this or next year).
  2. Try to implement this feature without adding breaking changes.

@ghost ghost force-pushed the JobSearch branch 5 times, most recently from dff0938 to e833f37 Compare July 19, 2016 08:12
@ghost ghost force-pushed the JobSearch branch from e833f37 to a1534d9 Compare August 10, 2016 13:42
@ghost ghost force-pushed the JobSearch branch from a1534d9 to a192b04 Compare August 22, 2016 14:53
Add search filter functionality to dashboard.
7e29b24 
* Will filter out specific failed jobs based on the arguments in each method call in each failed job.

* added automatic redirect to first page of FailedJobs when a new filter event occurs

* Added css styling to the filter textbox

* added filter on date functionality

* Divided Hangfire.js into 5 smaller files

* filter functionality implemented for enqueued, scheduled, processing, succeeded, failed and deleted job pages.

* removed redundant test project from solution

* Replaced overloaded Pager constructors with one constructor with default null values on parameters

* added state validation for JobCountByStateName() method

* javascript added for time picker

* Implemented text, date and time filtering on all pages. Works as long as no number is in the string!

* Sql bug fixed itself somehow. Fixed small bugs in code and changed visualisation style for dates on every job page.

* Feature switch working, set "EnableSearch" and "RelativeTime" when making the Dashboard options in Startup.cs

Merge fixes
@ghost ghost force-pushed the JobSearch branch from a192b04 to 7e29b24 Compare September 5, 2016 12:40
@pieceofsummer pieceofsummer mentioned this pull request Nov 8, 2016
Open
@suadev
Copy link
Copy Markdown

suadev commented Oct 15, 2017

https://github.com/suadev/chrome-hangfire-search-extension

@amiralgazi
Copy link
Copy Markdown

amiralgazi commented Jul 4, 2019

@odinserj Is there an estimate for version 2.0 development? Will this PR be part of it?

Are there other alternatives for search filter?
The chrome extension above doesn't work properly.

@eduardoalba
Copy link
Copy Markdown

eduardoalba commented Aug 6, 2019

@odinserj Is there an estimate for version 2.0 development? Will this PR be part of it?

Are there other alternatives for search filter?
The chrome extension above doesn't work properly.

I'm waiting for this feature too!

@Cyril-hcj
Copy link
Copy Markdown

Cyril-hcj commented Dec 16, 2021

@odinserj Is there an estimate for version 2.0 development? Will this PR be part of it?
Are there other alternatives for search filter?
The chrome extension above doesn't work properly.

I'm waiting for this feature too!

waiting

@Cyril-hcj
Copy link
Copy Markdown

Cyril-hcj commented Dec 16, 2021

Awesome contribution, @stevetsang! But it contains breaking changes to the public IMonitoringApi interface. If I merge this PR, a lot of projects must be updated (including all the storages listed here), a lot of people who use the interface in their applications will be required to perform additional tasks also.

I've constrained 1.x versions to not to have breaking changes between releases. There are a lot of deprecated stuff I'd like to remove too, and a lot of interfaces I'd like to change (), but I simply can't do this – it will break the expectations and raise a lot of questions after upgrade.

There are two ways to get this feature done:

  1. Wait until 2.0 development will begin (I don't know when, this or next year).
  2. Try to implement this feature without adding breaking changes.

Five years have passed

@abelbraaksma abelbraaksma mentioned this pull request Nov 2, 2023
Open
@abelbraaksma
Copy link
Copy Markdown

abelbraaksma commented Nov 2, 2023 •
edited
Loading

If @ghost is still around, could this change be made without being backwards incompatible? I.e., adding a new interface as opposed to changing an existing one?

Edit: it is a deleted user.... So someone else may be able to pick this up? Takers? 😄

@fairking fairking mentioned this pull request Jun 6, 2024
Open
@edelciomolina
Copy link
Copy Markdown

edelciomolina commented Jul 25, 2024

Until this is ready, this can help you find jobs quickly.
#988 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@odinserj @suadev @amiralgazi @eduardoalba @Cyril-hcj @abelbraaksma @edelciomolina