[regexp] Use required literal filter to speed up matching - #502
Merged
Conversation
Hans-Halverson
force-pushed
the
regexp-literal-filters-search
branch
2 times, most recently
from
August 12, 2026 00:34
853a62f to
74706ba
Compare
Hans-Halverson
force-pushed
the
regexp-literal-filters-search
branch
from
August 12, 2026 00:37
74706ba to
fe767fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the
RequiredLiteralFilterintroduced in #501 during matching. This filter allows us to 1) filter out any inputs that never contain the required literal and 2) if the literal has a known bound from the start of the match, restricts match start positions that need to be checked. Is used in combination with theMatchStartFilterin order to further optimize where the backtracking matcher even needs to be run.Notes:
HeapTwoByteCodePointLexerStreamto account for code points that take two code units.Seeing a massive +62.6% increase to Octane RegExp benchmark score from this change, an a +3.3% overall improvement to Octane score.
Tests