fix: pin pygments<2.20.0 to avoid pymdownx highlight crash#61
Conversation
WalkthroughThis PR adds Pygments as a development dependency with version constraints to the project's configuration, pinning it between versions 2.18.0 and 2.20.0. ChangesDevelopment Dependency Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pyproject.toml (1)
42-42: ⚡ Quick winAdd documentation explaining the Pygments version constraint.
The version pinning is appropriate—Pygments 2.20.0 introduced a change that breaks pymdownx.highlight, causing AttributeError crashes with code blocks. Pinning
<2.20.0is the correct approach. Consider adding a comment above line 42 to document this constraint for future maintainers, either directly in pyproject.toml or in a related issue reference.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pyproject.toml` at line 42, Add a short comment near the "pygments>=2.18.0,<2.20.0" dependency in pyproject.toml documenting why the upper bound is set: note that Pygments 2.20.0 introduced changes that break pymdownx.highlight (causing AttributeError with code blocks) and reference either the related issue/PR or its tracker URL for future follow-up; ensure the comment mentions "pygments" and "pymdownx.highlight" so maintainers can find context quickly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@pyproject.toml`:
- Line 42: Add a short comment near the "pygments>=2.18.0,<2.20.0" dependency in
pyproject.toml documenting why the upper bound is set: note that Pygments 2.20.0
introduced changes that break pymdownx.highlight (causing AttributeError with
code blocks) and reference either the related issue/PR or its tracker URL for
future follow-up; ensure the comment mentions "pygments" and
"pymdownx.highlight" so maintainers can find context quickly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 80a318c2-66fd-46fd-8c39-f3a97a7c9088
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
Summary by CodeRabbit