Port various systems/patterns from 2ship#5529
Open
garrettjoecox wants to merge 1 commit intoHarbourMasters:developfrom
Open
Port various systems/patterns from 2ship#5529garrettjoecox wants to merge 1 commit intoHarbourMasters:developfrom
garrettjoecox wants to merge 1 commit intoHarbourMasters:developfrom
Conversation
aa2e55e to
ebad187
Compare
Malkierian
approved these changes
Jun 5, 2025
Pepper0ni
suggested changes
Jun 12, 2025
Contributor
Pepper0ni
left a comment
There was a problem hiding this comment.
While I can't comment on a lot of hook stuff, I did see an issue in the custom message handling.
ebad187 to
069044a
Compare
serprex
reviewed
Jan 2, 2026
d13202c to
8f505be
Compare
Contributor
Author
8f505be to
96e3a96
Compare
Contributor
|
Small conflict in CustomMessageManager cropped up, then I think this can go in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This back-ports various systems/patterns from my findings on 2ship.
ShouldActorSpawn&OnOpenText- self explanatory new hooksCustomMessageconcept, but the patterns still all apply. Allows you to on-the-fly replace or create a new message and display it without having to go through the message table mechanism.None of these new systems are actually used anywhere yet, this PR simply introduces them, I will have a follow up migrating the Randomizer & Vanilla item give queues to use these.
Build Artifacts