Logic DSL

[serprex]

used #5674 to export logic to s-expressions & generate cpp file instead

This opens up various future improvements:

• output Python code for Archipelago
• output AST structure so Logic Tracker/Viewer #5674 doesn't have to parse it
• output logic to C to improve compile time
• output code in a way where logic tracks dependencies so when event/progression happens don't need to reevaluate everything
• generate randomizer types
• generate entrance rando tables (& also handle multiple paths to a shuffled entrance by automating creating pseudo entrance?)

Build Artifacts

• soh-linux.zip
• soh-windows.zip
• soh-mac.zip

[Pepe20129]

Will this require logic be written in this new format or will logic.s be generated from the current C++ logic?

[serprex]

Will this require logic be written in this new format or will logic.s be generated from the current C++ logic?

Yes, logic will be written in new format. Going to split up logic.s soon, but this become the new source, cpp is just generated (& switching output to C is high on my followups)

[Pepe20129]

I really don't like the new format, imo it makes logic harder to read & write.
Specially the prefix notation instead of infix notation but also some other minor things like using or instead of ||, using and instead of &&, the lack of parenthesis for function calls, the fact that there's no indentation whatsoever making it harder to know which checks are from which regions at a glance, etc

[serprex]

Prefix notation is in the air, s-expressions have the benefit of being the absence of syntax. Syntax is minor, discussion seemed to get overly hung up on it. So wanted to get something out that can discuss other aspects, & then transform can apply syntax afterwards. I would suggest that you try & view this without a C perspective. Really I'd prefer if this had syntax more like Haskell

There's not much indentation in the existing logic files, but have already received feedback about keeping //Events //Locations //Exits comments to section things

So I'm trying to address most of what you're pointing out, but on function calls this is actually pretty important for them to look the same as logical flags. There's designs to make logic code reactive, like S.js. They're stuck with JS so every getter has to be explicitly called, whereas we have the benefit of having this layer to skip that

Whether something is a function call without arguments or a field is irrelevant to logic. It's an implementation detail, & in fact the point is that we should be able to change the implementation underneath (or have generators with different implementation) without having to rewrite logic. These are all potentially reactive values

[serprex]

Archipelago output would want to look like aMannus/Archipelago#6