Open
Conversation
serprex
reviewed
Jan 19, 2026
serprex
reviewed
Jan 19, 2026
Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
serprex
reviewed
Mar 9, 2026
|
|
||
| #define RANDO_ENUM_ITEM(enum) { enum, #enum }, | ||
|
|
||
| std::unordered_map<RandomizerTrick, std::string> trickNames = { |
Member
There was a problem hiding this comment.
this map wouldn't be needed if json identified tricks by their codename like settings do
Contributor
Author
There was a problem hiding this comment.
I think it's better to not use the codename in this case, if a trick has its name changed, it probably also needs a change to the name & description, using the rg in the lang key makes it easier to notice.
Also, this is just the introduction of the system, there's not even a way to switch language at runtime (or at all in terms of UI) so it can be rethought later.
serprex
reviewed
Mar 9, 2026
serprex
approved these changes
Mar 9, 2026
Member
serprex
left a comment
serprex
left a comment
There was a problem hiding this comment.
lgtm, would like to get other's thoughts here tho
This reverts commit 2c047c0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the basis for a language system to allow the UI to be translated to any language and/or have the text changed by mods.
A lot of things would require more work but, for a proof of concept, this PR makes all randomizer trick names & descriptions translatable (currently not re-loadable at runtime as that would require deeper changes and this is already merge conflict hell every time a trick is touched).
The language change widget is currently not registered into the UI as it should probably be improved (and everything made re-loadable) before being accessible.
The system works by passing it a "translation path" which is resolved in the
.jsonincluding object indentation. If the resulting json object is a list of strings, instead of a string, they get concatenated (purely for organization/QoL).Build Artifacts