Skip to content

Add menu item to change upscale method#6236

Open
coavins wants to merge 6 commits intoHarbourMasters:developfrom
coavins:upscale-nearest
Open

Add menu item to change upscale method#6236
coavins wants to merge 6 commits intoHarbourMasters:developfrom
coavins:upscale-nearest

Conversation

@coavins
Copy link
Contributor

@coavins coavins commented Feb 7, 2026

This PR adds a menu item to set the upscaling method to nearest neighbor.

Depends on Kenix3/libultraship#1003

Resolves #6234

Build Artifacts

@coavins
Copy link
Contributor Author

coavins commented Feb 7, 2026

Screenshot from 2026-02-07 15-00-48

@serprex serprex requested a review from Malkierian February 8, 2026 22:27
@Malkierian
Copy link
Contributor

You'll need to add CVAR_UPSCALE_FILTER to CMake/lus_cvars.cmake with the CVAR_PREFIX_SETTING macro. Also, you need to run clang format.

@Malkierian
Copy link
Contributor

Ohhh, I see why this build is failing. The branch used for this PR isn't pointing to your LUS branch that's being submitted in that LUS PR. In order to build, until that's merged, you'll need to point it to that. After it's merged, you can just update the LUS ref here to the latest commit hash.

@coavins
Copy link
Contributor Author

coavins commented Feb 15, 2026

Sorry, it should be pointing at the right LUS branch now. I wasn't sure whether that should be included here.

@Malkierian
Copy link
Contributor

Malkierian commented Feb 15, 2026

Latest build log:

D:\a\Shipwright\Shipwright\libultraship\src\fast\backends\gfx_direct3d11.cpp
D:\a\Shipwright\Shipwright\libultraship\src\fast\backends\gfx_direct3d11.cpp(780): error C2039: 'Filter': is not a member of 'D3D11_TEXTURE2D_DESC'
C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\um\d3d11.h(2812): note: see declaration of 'D3D11_TEXTURE2D_DESC'

I'd assume the Mac issue is similar, but with Metal.

@coavins
Copy link
Contributor Author

coavins commented Feb 15, 2026

Should be resolved now, I also fixed the potential sampler issue with the metal backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No option for nearest neighbor when upscaling from N64 resolution

2 participants