Claude authored PCH & Unity Builds

[garrettjoecox]

Take or leave it, not really something I put effort into and I don't fully understand the downsides of PCH or Unity builds, but it's something that has gone smoothly on 2ship for a while now.

Completely fresh build on my macbook m4

develop: 240s
pch-unit: 79s

Build Artifacts

• soh-linux.zip
• soh-mac.zip
• soh-windows.zip

[serprex]

Build improvements always welcome

HarbourMasters/2ship2harkinian#1358 is all I can find looking up pch on 2ship, & not seeing similar pattern in CMakeLists.txt. Is there a different PR to use for comparison?

[louist103]

I think it would be more worth it to fix the header bloat problem first. Using something like https://include-what-you-use.org

[garrettjoecox]

Build improvements always welcome

HarbourMasters/2ship2harkinian#1358 is all I can find looking up pch on 2ship, & not seeing similar pattern in CMakeLists.txt. Is there a different PR to use for comparison?

That's the one, though I realize that was just PCH not unity builds, going to be trying unity builds on 2ship now

[serprex]

I'd prefer to start with just PCH, unity builds seem to have some drawbacks I'm hesitant towards, & think louist's suggestion to clean up header usage first is something I can look into

[Pepe20129]

There's also the idea to use C++ 20 modules when possible, that'd require a lot more work but it's worth keeping in mind.

[louist103]

There's also the idea to use C++ 20 modules when possible, that'd require a lot more work but it's worth keeping in mind.

That is an option but they break edit and continue and I don't think they are fully supported by all platforms yet.