feat: show what the model flagged on the Changes tab - #135
Merged
Merged
Conversation
The model's review notes were produced on every sync and then discarded: nothing stored them and nothing showed them. They are now sealed with the source version they describe, alongside its evidence, and the Changes tab opens with what to check: parts that could not be read, wording to compare with the ANU page, and the fields the model was least sure of, in words an administrator reads rather than extraction paths.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows #134. Review is the only check on a model-owned sync, but the model's own notes were produced on every sync and then thrown away: nothing stored them and nothing showed them.
Stored. A new
catalogue_version_flagstable holds each source version's flags, sealed with the version like its provenance. Only catalogue reviewers can read it (can_read_catalogue_drafts), and it is not part of the content hash, so notes never create a review on their own.Shown. The Changes tab opens with What to check:
Field names read as an administrator knows them:
requisites.prerequisiteRulebecomes "Prerequisite rule" andrequirements.rule.children.3becomes "Requirements, branch 4". The section is absent when nothing was flagged.Verification
pnpm verifywas not rerun on this branch)apps/web/types/database.tsis committed from the Database gate's own generator output, so that gate is the check.Deployment notes
011_catalogue_version_flags.sqlcreates the table, its seal trigger, row-level security, a reviewer read policy and grants. A pgTAP test covers the access boundary.