fix(install): correct stale ORVA_SKIP_VERIFY checksum comment#24
Merged
Conversation
The comment claimed checksum verification is "fail-closed unless ORVA_SKIP_VERIFY=1", but ORVA_SKIP_VERIFY is not implemented anywhere and verify() is actually fail-OPEN on a MISSING checksum (warns + skips per asset) while a checksum MISMATCH aborts via die(). Rewrite the comment to match the real behavior; no functional change. Also drop the now-obsolete "stale comment" note from scripts/CLAUDE.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only fix in
scripts/install.sh: it claimed checksum verification is "fail-closed unless ORVA_SKIP_VERIFY=1", butORVA_SKIP_VERIFYis not implemented andverify()is fail-open on a missing checksum (warns + skips) while a mismatch aborts viadie(). Rewrites the comment to match reality; no functional change. Also drops the now-obsolete "stale comment" note fromscripts/CLAUDE.md. shellcheck (ci.yml) + e2e run on this since it touches a.shfile.