Refactor FsEdgeLine source code: modernize formatting and translate comments#38
Draft
Refactor FsEdgeLine source code: modernize formatting and translate comments#38
Conversation
Co-authored-by: Hashory <89839285+Hashory@users.noreply.github.com>
Co-authored-by: Hashory <89839285+Hashory@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] 以下の手順に従って、
Refactor FsEdgeLine source code: modernize formatting and translate comments
Aug 22, 2025
Source/Effects/FsEdgeLine ディレクトリ内のソースコード(.cpp, .h ファイル)をリファクタリングしてください。
**作業内容:**
**ステップ1: コードの手動修正**
対象�...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
Source/Effects/FsEdgeLinedirectory to modernize the codebase and improve maintainability by implementing the following changes:Changes Made
1. Code Cleanup and Modernization
//-------,//======) that cluttered the code#ifndef/#define/#endifinclude guards with modern#pragma oncedirectives in all header files2. Include Order Protection
Added
// clang-format offand// clang-format ondirectives around include blocks in all source files to prevent automatic reordering by formatting tools, preserving the carefully arranged header dependencies.3. Code Formatting
.clang-format-ignore: Commented out theSource/Effects/FsEdgeLine/*entry to enable clang-format processingFiles Modified
Source/Effects/FsEdgeLine/EdgeLine.cpp(377 → 361 lines)Source/Effects/FsEdgeLine/EdgeLine.h(112 → 109 lines)Source/Effects/FsEdgeLine/Fs_Entry.h(226 → 212 lines)Source/Effects/FsEdgeLine/Fs_Target.h(72 → 68 lines).clang-format-ignoreBenefits
#pragma onceinstead of traditional include guardsThe refactored code maintains full functional compatibility while significantly improving code quality and adherence to modern C++ standards.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.