Refactor: Clean up and format FsCCplus source code#40
Merged
Conversation
This commit refactors the C++ source code in the `Source/Effects/FsCCplus` directory. The following changes were made: - Removed unnecessary decorative and historical comments. - Translated all Japanese comments to English for better readability and maintenance. - Replaced traditional `#ifndef` include guards with `#pragma once` in header files. - Wrapped `#include` blocks with `// clang-format off/on` to prevent reordering by formatters. - Applied clang-format to the entire directory for consistent code style. This commit also corrects a mistake in the initial refactoring of `Fs_Entry.h` where a necessary block of includes was removed instead of being uncommented and refactored.
Hashory
approved these changes
Aug 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request applies a series of refactoring and formatting improvements to the source code within the
Source/Effects/FsCCplusdirectory, following the user's detailed instructions. The changes include removing obsolete comments, translating all Japanese comments to English, standardizing include guards to use#pragma once, protecting include blocks from reordering, and applyingclang-formatfor consistent code style.This update also addresses a correction for
Fs_Entry.h, which was improperly modified in the initial attempt. The file has been restored and correctly refactored to ensure all necessary includes are present.