Improve testing workflow to select correct environment and handle pandas / python version for map function#12
Merged
HawkMRS merged 6 commits intoHawkMRS:devfrom Jan 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jia,
this pull request introduces improvements to both the testing workflow and the codebase to enhance compatibility across development environments.
Testing workflow updates:
.github/workflows/test-notebooks.ymlandpytest.inito use the--nbval-current-envflag, ensuring that notebook tests run in the current Python environment rather than a potentially isolated one.Pandas / Python version compatibility:
backward_compatible_mapfunction to handle differences between pandas versions (mapfor >=2.1.0,applymapfor older versions). This is similar to your commit last week, but should improve maintainability.Minor bug fix:
unitconverterby removing unnecessary type casting, relying on prior numeric conversion.