Skip to content

fix: use PEP 508 environment markers for hlsvdpro (Resolves #15) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewendlinger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use PEP 508 environment markers for hlsvdpro (Resolves #15) #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import ast
import glob
import os
import platform

from setuptools import find_packages, setup
from setuptools.command.sdist import sdist as _sdist
Expand Down Expand Up @@ -95,14 +94,13 @@ def run(self):
"requests",
"ipywidgets>=7.6.0,<8.0.0;python_version<'3.11'", # For older Python versions
"ipywidgets>=8.0.0;python_version>='3.11'", # For newer Python versions
# Use the better-performing 'hlsvdpro' package if running on supported platforms
# (e.g., x86_64 or amd64 architectures). Otherwise, fall back to the custom
# 'hlsvdpropy' implementation located in pyAMARES/libs/hlsvd.py.
# (Refactored to PEP 508 markers in Issue #15 for Apple Silicon/uv compatibility)
"hlsvdpro>=2.0.0; platform_machine == 'x86_64' or platform_machine == 'amd64'",
]

# Use the better-performing 'hlsvdpro' package if running on supported platforms
# (e.g., x86_64 or amd64 architectures). Otherwise, fall back to the custom
# 'hlsvdpropy' implementation located in pyAMARES/libs/hlsvd.py.
if platform.machine().lower() in ["x86_64", "amd64"]:
install_requires.append("hlsvdpro>=2.0.0")


setup(
name="pyAMARES",
Expand Down
Loading