Skip to content

test(platform): add proof-status index visibility#30

Merged
raylee-hawkins merged 1 commit into
mainfrom
phase2e/platform-proof-status-visibility-sync
May 20, 2026
Merged

test(platform): add proof-status index visibility#30
raylee-hawkins merged 1 commit into
mainfrom
phase2e/platform-proof-status-visibility-sync

Conversation

@raylee-hawkins
Copy link
Copy Markdown
Contributor

Adds Phase 2E platform proof-status visibility sync.

Summary:

  • Surfaces proof-status index visibility through platform factory/status/plan outputs.
  • Updates Detection Factory Controller v0 schema/examples/docs for proof-status fields.
  • Keeps proof truth owned by hawkinsoperations-proof.
  • Keeps platform as status/plan/visibility layer only.
  • Preserves runtime, signal, public-safe, and website boundaries.

Boundary:

  • Platform visibility only.
  • No proof promotion.
  • No public-safe promotion.
  • No runtime or signal promotion.
  • No website update.
  • No detections, validation, proof, or .github edits.
  • No GitHub settings, ruleset, workflow, or branch-protection changes.

Copy link
Copy Markdown
Contributor Author

@raylee-hawkins raylee-hawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed as Phase 2E platform proof-status visibility sync.

Scope confirmed:

  • Platform surfaces proof-status index visibility in factory/status/plan outputs.
  • Proof truth remains owned by hawkinsoperations-proof.
  • Platform remains visibility/status/plan layer only.
  • Website remains untouched.

Claim boundary confirmed:

  • No proof promotion.
  • No public-safe promotion.
  • No runtime-active public proof.
  • No signal-observed public proof.
  • No production-ready or fleet-wide claim.
  • No autonomous SOC claim.
  • No AI-approved or analyst-approved disposition claim.

Governance decision:
Ready for merge as platform visibility integration only. Website/public routing remains blocked until separately scoped.

@raylee-hawkins raylee-hawkins merged commit d5cbb86 into main May 20, 2026
2 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ef356b831

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/ho_factory.py
Comment on lines +1967 to +1968
if yaml is None:
raise FactoryError("PyYAML is required to read the proof status index")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove undeclared PyYAML runtime dependency

This introduces a hard dependency on PyYAML for normal status/plan packet generation (load_proof_status_index raises as soon as yaml is unavailable), but the repository does not declare or bootstrap that dependency. On runners that previously executed this controller with only stdlib dependencies, packet builds now fail immediately before emitting output, which is a functional regression for the new visibility path.

Useful? React with 👍 / 👎.

Comment thread scripts/ho_factory.py
Comment on lines +2049 to +2050
"source_status": entry["source_status"],
"validation_status": entry["validation_status"],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Validate proof-index fields before direct subscripting

The new visibility payload reads source_status and validation_status via direct subscripting without prior presence/type checks. If the index entry is malformed or partially missing, this throws KeyError instead of FactoryError; since main() only handles FactoryError, the controller exits with an uncaught traceback rather than the intended fail-closed error path.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant