test(platform): add proof-status index visibility#30
Conversation
raylee-hawkins
left a comment
There was a problem hiding this comment.
Reviewed as Phase 2E platform proof-status visibility sync.
Scope confirmed:
- Platform surfaces proof-status index visibility in factory/status/plan outputs.
- Proof truth remains owned by hawkinsoperations-proof.
- Platform remains visibility/status/plan layer only.
- Website remains untouched.
Claim boundary confirmed:
- No proof promotion.
- No public-safe promotion.
- No runtime-active public proof.
- No signal-observed public proof.
- No production-ready or fleet-wide claim.
- No autonomous SOC claim.
- No AI-approved or analyst-approved disposition claim.
Governance decision:
Ready for merge as platform visibility integration only. Website/public routing remains blocked until separately scoped.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ef356b831
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if yaml is None: | ||
| raise FactoryError("PyYAML is required to read the proof status index") |
There was a problem hiding this comment.
Remove undeclared PyYAML runtime dependency
This introduces a hard dependency on PyYAML for normal status/plan packet generation (load_proof_status_index raises as soon as yaml is unavailable), but the repository does not declare or bootstrap that dependency. On runners that previously executed this controller with only stdlib dependencies, packet builds now fail immediately before emitting output, which is a functional regression for the new visibility path.
Useful? React with 👍 / 👎.
| "source_status": entry["source_status"], | ||
| "validation_status": entry["validation_status"], |
There was a problem hiding this comment.
Validate proof-index fields before direct subscripting
The new visibility payload reads source_status and validation_status via direct subscripting without prior presence/type checks. If the index entry is malformed or partially missing, this throws KeyError instead of FactoryError; since main() only handles FactoryError, the controller exits with an uncaught traceback rather than the intended fail-closed error path.
Useful? React with 👍 / 👎.
Adds Phase 2E platform proof-status visibility sync.
Summary:
Boundary: