ds_notice with success banner and custom banner text #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilisLiu
changed the title
timgentry
approved these changes
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Support
ds_noticewith success banner (rendered in green) and custom banner textWhy?
Use a success banner to confirm an action on a previous page was successful. For example, for steps in a long journey or small repeated tasks.
Both GOVUK and NHSUK have this so we should probably have it too
How?
ds_noticetakes two more keyword arguments now - 'header' and 'type'available types:
:informationand:success(default to information), each coming with their own default text which could be overrodeTesting?
All passed
Screenshots (optional)
GOVUK:
NHSUK:
Anything Else?
No