Skip to content

fix(snapshot): refuse receipt paths that escape the handed directory - #515

Open
VARUN3WARE wants to merge 1 commit into
Hebbian-Robotics:mainfrom
VARUN3WARE:fix/snapshot-verify-path-escape
Open

fix(snapshot): refuse receipt paths that escape the handed directory#515
VARUN3WARE wants to merge 1 commit into
Hebbian-Robotics:mainfrom
VARUN3WARE:fix/snapshot-verify-path-escape

Conversation

@VARUN3WARE

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Relative ../, absolute path, and tables/../../… (subdir present) → exit 2
  • Honest relative export still verifies clean
  • tests/test_snapshot_verify.py + tests/test_dataset_snapshot.py
  • CI green

Reuse storage._validated_relative_key so verify_dataset_snapshot raises
(exit 2) before reading absolute or .. paths, matching the documented
join-only-onto-the-handed-root promise (Hebbian-Robotics#469).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Snapshot verify can read outside the handed directory via receipt paths

1 participant